From a0881c9a8dbff2bf7f3e10255b998b9529c7aef3 Mon Sep 17 00:00:00 2001
From: yangys <y_ys79@sina.com>
Date: 星期四, 07 八月 2025 13:46:36 +0800
Subject: [PATCH] 优化代码
---
blade-service/blade-mdm/src/main/java/org/springblade/mdm/flow/service/ApproveRecordService.java | 53 +++++++----------------------------------------------
1 files changed, 7 insertions(+), 46 deletions(-)
diff --git a/blade-service/blade-mdm/src/main/java/org/springblade/mdm/flow/service/ApproveRecordService.java b/blade-service/blade-mdm/src/main/java/org/springblade/mdm/flow/service/ApproveRecordService.java
index acf9997..2ac2343 100644
--- a/blade-service/blade-mdm/src/main/java/org/springblade/mdm/flow/service/ApproveRecordService.java
+++ b/blade-service/blade-mdm/src/main/java/org/springblade/mdm/flow/service/ApproveRecordService.java
@@ -1,7 +1,6 @@
package org.springblade.mdm.flow.service;
-import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import lombok.AllArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.StringUtils;
@@ -12,9 +11,7 @@
import org.springblade.mdm.flow.entity.ApproveRecord;
import org.springblade.mdm.flow.mapper.ApproveRecordMapper;
import org.springblade.mdm.flow.vo.ApproveRecordVO;
-import org.springblade.mdm.program.entity.ProcessProgRef;
import org.springblade.mdm.program.service.ProcessProgRefService;
-import org.springframework.beans.BeanUtils;
import org.springframework.stereotype.Service;
import java.util.List;
@@ -34,9 +31,9 @@
return this.getBaseMapper().listByNcProgramId(ncProgramId);
}
- public void saveApproveRecords(Task task, String processInstanceId, String operateResult, String comment) {
+ public void saveApproveRecords(Task task, String operateResult, String comment) {
- String processDefinitionKey = flowCommonService.getDefinitionKey(processInstanceId);
+ String processDefinitionKey = flowCommonService.getDefinitionKey(task.getProcessInstanceId());
ApproveRecord rec = new ApproveRecord();
rec.setTaskName(task.getName());
@@ -44,14 +41,15 @@
//rec.setNcProgramId(refObj.getNcProgramId());
rec.setOperateResult(operateResult);//瀹℃壒缁撴灉
rec.setOperateTime(DateUtil.now());
- rec.setProcessInstanceId(processInstanceId);
+ rec.setProcessInstanceId(task.getProcessInstanceId());
rec.setProcessDefinitionKey(processDefinitionKey);
+ rec.setTaskDefinitionKey(task.getTaskDefinitionKey());
rec.setUserId(AuthUtil.getUserId());
rec.setUserNickname(AuthUtil.getNickName());
save(rec);
}
-
+ /*
public void saveApproveRecordsOld(Task task, String processInstanceId, String operateResult, String comment) {
@@ -65,7 +63,7 @@
ApproveRecord rec = new ApproveRecord();
rec.setTaskName(task.getName());
rec.setComment(comment==null? StringUtils.EMPTY:comment);
- rec.setNcProgramId(refObj.getNcProgramId());
+
rec.setOperateResult(operateResult);//瀹℃壒缁撴灉
rec.setOperateTime(DateUtil.now());
rec.setProcessInstanceId(processInstanceId);
@@ -76,8 +74,6 @@
save(rec);
}
- //妫�鏌cprogram涓簄ull鐨勬暟鎹�
- updateApproveRecords(processInstanceId,refList);
}else{
//濡傛灉杩樻病鏈夊叧鑱旂殑绋嬪簭鏁版嵁锛屽垯鎻掑叆涓�涓猵rogramId涓簄ull鐨�
ApproveRecord rec = new ApproveRecord();
@@ -89,46 +85,11 @@
rec.setProcessDefinitionKey(processDefinitionKey);
rec.setOperateResult(operateResult);
rec.setOperateTime(DateUtil.now());
- rec.setNcProgramId(null);//绌虹殑绋嬪簭id
rec.setUserId(AuthUtil.getUserId());
rec.setUserNickname(AuthUtil.getNickName());
save(rec);
}
}
-
- /**
- * 鏇存柊浠ュ墠鏃犳枃浠舵椂鍊欑殑鏁版嵁銆�
- * @param processInstanceId
- */
- void updateApproveRecords(String processInstanceId,List<ProcessProgRef> refList) {
-
- if(refList.isEmpty()) {
- return;
- }
- List<ApproveRecord> records = this.lambdaQuery().isNull(ApproveRecord::getNcProgramId).eq(ApproveRecord::getProcessInstanceId, processInstanceId).list();
- if(records.isEmpty()) {
- return;
- }
-
- for(ApproveRecord record:records) {
-
- for(int j=0;j< refList.size();j++) {
- ProcessProgRef refObj = refList.get(j);
-
- ApproveRecord record2 = new ApproveRecord();
- BeanUtils.copyProperties(record, record2);
- record2.setNcProgramId(refObj.getNcProgramId());
-
- if(j>0){//鍚庣画鏁版嵁闇�瑕佹柊澧炴暟鎹�
- record2.setId(null);
- save(record2);
- }else{//绗竴鏉℃槸鏇存柊鍘熺邯褰�
- updateById(record2);
- }
- }
-
- }
-
- }
+ */
}
--
Gitblit v1.9.3